2008-7-10
| 19:48 | brosner | yeah there are some bits i can't do quite yet. |
| 19:49 | brosner | at this point leave it if you can |
| 19:49 | Honza | no problem, thanks |
| 19:52 | mrts | that's the idiom then, right http://dpaste.com/62191/ ? |
| 19:53 | brosner | rename meta to opts |
| 19:53 | mrts | ok |
| 19:54 | brosner | |
| 19:55 | mrts | I'm actually using docs/_build/html/admin.html as the base reference |
| 19:55 | mrts | but the idiom corresponds to the code segment you pasted |
| 19:56 | mrts | although they use a list of errors, not a simple raise foo |
| 19:56 | mrts | should I do that as well? |
| 19:57 | mrts | i.e. collect all errors and raise in the end |
| 19:57 | mrts | if errors: raise ImproperlyConfigured('\n'.join(errors)) in the end |
| 19:58 | mrts | design decision needed :) |
| 19:58 | brosner | hmm one second :) |
| 19:58 | mrts | (docs/_build/html/admin.html from nfa branch of course) |
| 20:00 | mrts | that would make the code flow more complex though, so I'd be -0.314 for that :) |
| 20:01 | mrts | (e.g. currently I can assume that raw_id_fields is a list or tuple if nothing has been raised so far in for field in raw_id_fields: |
| 20:02 | brosner | yeah lets not worry about it now |
| 20:02 | mrts | quite |
| 20:03 | Alex_Gaynor | mrts: You need to stop deleting stuff on dpaste, I'm going through the logs and I get nothing but 404s :P |
| 20:03 | mrts | sorry :) |
| 20:04 | mrts | I deleted the drafts and let the real things alone :) |
| 20:05 | mrts | http://dpaste.com/62167/ and http://dpaste.com/62191/ are currently relevant |
| 20:06 | mrts | (http://dpaste.com/62191/ is missing the overrides in sibling classes though) |
| 20:07 | Alex_Gaynor | Ok makes sense |
| 20:09 | zerok | gach, not my day |
| 20:09 | zerok | sorry for the dup |
| 20:11 | Honza | if anybody's bored I just uploaded new version of #6845 that applies against trunk, we have tested it on some real-life projects and everything seems to work. |
| 20:11 | DjangoBot | |
| 20:13 | zerok | brosner, regarding #5609 : do you want all the old class names back again? |
| 20:13 | DjangoBot | |
| 20:13 | brosner | ideally yes |
| 20:13 | zerok | ah ok |
| 20:14 | brosner | that should fix many of the visual inconsistencies between trunk and nfa |
| 20:14 | zerok | ok, perhaps i can do at least something useful today |
| 20:14 | brosner | :) |
| 20:32 | Alex_Gaynor | brosner: One of those tickets wasn't closed, I got it |
| 20:32 | brosner | did i give it the right ticket number? |
| 20:33 | Alex_Gaynor | Yeah |
| 20:33 | Alex_Gaynor | trac/svn is stoopid |
| 20:33 | brosner | its the post-commit hook |
| 20:33 | brosner | not sure why though |
| 20:33 | Alex_Gaynor | Me neither, but one of them is screwing up :P |
| 20:43 | jhenry | So after several hours of work, I've got something that is mildly entertaining. A modified core.cache api with get_or_set(key, value_function, timeout, stale_after_x_seconds) that uses threading to spawn a thread to set the value of the cache key if the immediately-returned value is stale, and a serve_stale_cache_page middleware that wraps the normal cache_page middleware which will always return quickly if the item is found in c |
| 20:43 | jhenry | Anyone interested? |
| 20:44 | jhenry | not middleware, decorator |
| 20:52 | Alex_Gaynor | brosner: nfa still uses QuerySetPaginator those should be switched to Paginator |
| 20:52 | brosner | it should have been fixed |
| 20:52 | Alex_Gaynor | oh did you get that with the merge? |
| 20:52 | brosner | yep. it conflicted :) |
| 20:53 | Alex_Gaynor | Hehe, smart, I need to learn to read :P |
| 22:23 | bernd79 | hi, how can I run tests for "localflavor" ? |
| 22:29 | cramm | bernd79: runtests.py forms |
| 22:30 | bernd79 | cramm: ok ic thanks |
| 23:31 | bernd79 | I wrote now a test for the localflavor I commited, should I do anything more? http://code.djangoproject.com/ticket/7686 |
| 23:40 | cramm | bernd79: meybe set need_tests to false and have patience :-) |
| 23:40 | bernd79 | ok unterstand, sorry i'm new to the system :) |
| 23:41 | cramm | don't worry |
| 23:41 | bernd79 | should I change "action" also? |
| 23:44 | cramm | I don't think so, leave it as new. A triager (marc) has already marked it as accepted, an hopefully soon another one will review the patch and mark as ready for checkin |
| 23:45 | bernd79 | ok coolio, i go to sleep now, bye |
Page 6 of 6
← Previous
(562 total)