DjangoBot: #django-dev

well your patch could still work

elliott, i'm trying to keep BackwardsIncompatibleChanges to a minimum :(

Yeah, I'm going to spend some more time with my patch right now

Alex_Gaynor: If you are thinking that this is the right direction let me get it so all the tests pass again. and then we can combine patches, test the hell out of it and try to get some support of the core devs

Gulopine: this does not count as official blessing, but I bet you could get away with it. utils is kinda frowned upon by some devs as a dumping ground. :)

jkocherhans, i was actually just thinking about moving it, but leaving the old module around with an import and a deprecationwarning :)

I'd be all for that.

it'll be interesting to count the DeprecationWarnings that get yanked when 1.0 is blessed

Newmaniese: Ok, the main difference between ours is that yours sets up the urls in the __init__ and mine does them in a getter

i'm introducing a crapton myself

Alex_Gaynor: let me pull back up your patch

Alex_Gaynor: I am sorry, I am dense. I decided to start from scratch and didn't even relize i duped a lot of things you already got done. You kept the root function too

Just as a refence

to keep track of what I have implemented

I really don't like the root function, it's kind of a hodge podge

it will go away

do we really need a break after a return? :)

Anyting still in root() means I don't have it in the URLconf

Yea, like the permissions checking

Let me finish that off and let's regroup

why hadn't the adminsite used urlconfs until now?

Ok, I'm adding the r/ urls now(which are the shortcuts)

the better organized i make everthing, the more everything breaks

Argh, why am I getting template daoes not exist: admin/index.html :(

OH SHIT

uh oh

and i thought *i* was breaking stuff

Hehe, not having admin in installedapps is bad

http://code.larlet.fr/doc/django-oauth-provider... my own django sprint for those interested in OAuth

Newmaniese: Ok, mine seems to be working, (minus a bunch of stuff),

I think we need to do the login decorator now

I have that all but done

I am running the tests

david`bgk: That's awesome.

ericflo, thanks :)

david, sweet! i was just gonna start looking into oauth

now i don't have to :)

heh, do not hesitate if you have any question

http://dpaste.com/63743/ new diff

Alex_Gaynor: Cool, I am just trying to abstract out some of the has_permission function. That is critical and the decorator is trying to wreak havok

Yeah, that's the current cause of all the test failures for me

Alex_Gaynor: It's taking me longer than expected. I am getting a few nasty errors. I am really liking this patch though. it makes a lot of sense. I need to run eat dinner. I will be back later.

Ok, can you post what you have on the decorator so far?

I don't like what I have because it requires has_permission out of the site

issue is that we need self availible somewhere in there

so my last try was in the _get_url function

That won't work because it doesn't have access to request

exactly my conumdrum right now

it should be possible: http://dpaste.com/63760/

Let me paste what I think it should look like

Does this look right: http://dpaste.com/63761/ I haven't tested it at all, but it seems to make sense(although we'll need a slightly altered version for model_admin since it doesn't get admin_site, instead it can use model_admin.admin_site)

except line 6 ;)

Like I said, completely untested :P

where adminsite is passed with self right?

you can just return admin_site(request)

Yeah, admin_site is the self param

No, admin_site doesn't have an __call__ method

login returning none should be fixed with this patch too

i am sorry, low blood sugar

I mean admin_site.login(request)

Yeah, I realize that will be fixed, I just meant that that's the analog of the current functionality, does it look right?

yep perfect, let's see if works

Ok, going to implement

God I can't wait for django to drop 2.3 compatibility, decorators ftw

I hear you

Ok, just did sites.py , now I need to make a model admin version and implement it

post it please!?!

yeah, seriously

(about the decorators)

I am real bad at doing try except finally in my code for 2.3

Ok, implemented : http://dpaste.com/63782/

I think there are still 2 test failures, but we're doing better :P

django officially supports 2.3, but we're not testing against it w/ buildbot, hmmm

tests are broken with 2.3 beecause we use sorted() a few times

I personally say screw it, lets drop 2.3 for 1.0

agreed

agreed

Alex_Gaynor: This is great

jacob or someone should post a poll on django-dev or users asking people to vote on whether they need 2.3 support

I will be back in a few to get the kinks ironed out. My stomac is starving

someone will need it

I think we still need it

I still have one box with 2.3 on it

Someone needs it, but if push came to shove could they upgrade?

2.3 isn't backwards incompatible is it?

err 2.4

Haha you're more than welcome to come build python 2.4 on my centos box....

I'll chat with you later

Hehe, ok, see you