2008-7-13
| 04:42 | Newmaniese | hopefully, we won't hold it up :) |
| 04:42 | Newmaniese | I agree |
| 04:45 | Newmaniese | Nice Work Alex_Gaynor I'll chat with you tomorrow morning |
| 07:24 | fijal | hello |
| 08:09 | david`bgk | cramm, unfortunately it doesn't fix the bug for me, I still got the same error |
| 15:45 | cramm | Hi guys, anyone running OS X and willing to test a script?. I'm trying to learn why a Django test (trying loading a template from an egg) fails |
| 15:50 | cramm | s/learn/digg/ |
| 16:02 | Newmaniese | cramm: you still looking for a mac tester? |
| 16:02 | cramm | Newmaniese: oh yes. http://dpaste.com/64198/ |
| 16:03 | cramm | Newmaniese: that's a standalone copy of tests/regressiontest/templates/loaders.py and django/template/loaders/eggs.py |
| 16:04 | Newmaniese | ok I'll run it quick |
| 16:05 | cramm | Newmaniese: we have a test templates that is failing both under win32 and mac os x. I found how to solve it under win32 but I can't understand why it keeps failing under os x |
| 16:05 | cramm | the failure itself can be triggered by runnning Django's ./runtests --verbosity=2 templates |
| 16:06 | cramm | Newmaniese: oh, forgot to ask this first: Do you have setuptools? |
| 16:06 | Newmaniese | cramm: nope I am realizing that is failing right now |
| 16:06 | Newmaniese | I can install them quick |
| 16:07 | cramm | Oh that would be great |
| 16:07 | jezdez | ping me if you need more testers |
| 16:07 | cramm | ok |
| 16:08 | cramm | in [7751] Adrian modified these tests to not be execised if setuptools isn't present |
| 16:10 | Newmaniese | cramm: I am getting an error in the script: http://dpaste.com/64201/ |
| 16:12 | cramm | I forgot to delete that line. But the fact that you reach that point would mean the Django test doesn't fail on your system |
| 16:12 | cramm | Weird |
| 16:13 | Newmaniese | python 2.5 mac osx 10.5.4 and I just got the latest version of setup tools |
| 16:13 | Newmaniese | Should I delete the return? just to see if the thing can finish |
| 16:13 | cramm | someone else also running reports it fails for him: http://dpaste.com/59930/ |
| 16:13 | cramm | Newmaniese: yes please |
| 16:14 | Newmaniese | cramm: another error: http://dpaste.com/64202/ |
| 16:15 | Newmaniese | because it isn;t returning anything :) |
| 16:15 | cramm | yeap :), I made a mess of that part |
| 16:16 | Newmaniese | There we go: does this look right: http://dpaste.com/64216/ |
| 16:16 | Newmaniese | I just uncommented the line 30 |
| 16:20 | cramm | Newmaniese: Thanks. So I now need to understand why is doesn't fails always. Will ask the reporter about the versions of pieces he is using, I only know he has setuptools 0.6c8 |
| 16:21 | Newmaniese | cramm: Yep that's the version I have. Ping me if there is any other way that I can help, I don't know much about eggs, but I do have a Mac :) |
| 16:21 | cramm | Ok, thanks again :) |
| 17:20 | jezdez | in newforms-admin, will django.contrib.admin.autodiscover() be the prefered way to deal with auto-register? |
| 18:40 | Newmaniese | Hey brosner |
| 18:40 | Alex_Gaynor | Arg, almost forgot to ask him! |
| 18:41 | Newmaniese | Haha figured he was on might as well |
| 18:42 | Alex_Gaynor | Defniitely, it just slipped my mind |
| 18:42 | Newmaniese | I am looking at the templates now and trying to figure out how to reverse the model_admin names |
| 18:43 | Alex_Gaynor | Hrm, yeah, we'd need to be able to do some sort of string iterpolation |
| 18:43 | Newmaniese | I am thinking It might be better to pass the model stuff as args |
| 18:44 | Alex_Gaynor | You mean make a custom admin_url tag? |
| 18:45 | brosner | hey Newmaniese. i will be doing some django code in about an hour. mind pinging me then? |
| 18:46 | Newmaniese | Sure Alex_Gaynor and I have some things for you to take a look at |
| 18:46 | Alex_Gaynor | Ok, I'm leaving in about 15 minutes, but Newmaniese knows what it is |
| 21:25 | Newmaniese | Hey brosner. Now good? |
| 21:26 | brosner | yeah |
| 21:27 | Newmaniese | Alex_Gaynor and I (mostly Alex_Gaynor) worked up a patch that fixes reverse in NFA. Only issue we are having is one test fails. It's the test where you monkey patch in the extra_context |
| 21:28 | Newmaniese | This fails because we are using the traditional url_conf and so the urls and the methods are stored at the URL level. So monkey patching like that won't work |
| 21:29 | Newmaniese | we messed around with it and we could create a lazy_loader or a factory function or we could just drop support for that style of monkey patching, which isn't supported anywhere else in django |
| 21:30 | brosner | hmm, are you sure you meant extra_context? |
| 21:31 | Newmaniese | it's the way the admin views test does it on line 279 |
| 21:32 | Newmaniese | here is the still rough patch: http://dpaste.com/64358/ |
| 21:39 | brosner | ideally to make this all work there needs to be some changes upstream in urlresolvers |
| 21:40 | Newmaniese | We added one line to support objects passed into RegexURLResolver |
| 21:42 | Newmaniese | but that's the only change, nothing else is affected |
| 21:43 | Newmaniese | I guess the question is: If we want to continue support for items like that test that occur after runtime |
| 21:47 | apollo13 | Newmaniese: your patch has one very positive sideeffect, it's now really easy to add some custom views into the admin, just by overriding urls :) |
| 21:47 | brosner | thats always been possible apollo13 :) |
| 21:48 | brosner | until nfa changes |
| 21:48 | apollo13 | brosner: must have missed something :) |
| 21:48 | apollo13 | I don't follow you |
| 21:49 | brosner | you have always been able to override urls using urlpatterns since they short-curcuit, but nfa made that a bit harder |
| 21:49 | brosner | and technially that is still possible |
| 21:50 | apollo13 | brosner: of course, but that would remember them to put them before the admin include (if I understand you right), with this patch it would be tied to the adminsite/modeladmin, so there is no need for the user to edit anything |
| 21:51 | apollo13 | hmm let me write that one again^^ |
| 21:51 | apollo13 | but that would require me to ... |
| 21:54 | Newmaniese | apollo13: I think this method is a little more traditional, but adding views is one of the main goals of NFA |
| 21:54 | apollo13 | indeed |
| 21:55 | brosner | Newmaniese: not really. it would be a nice side-effect, but was never the intension since for now it will likely stay the same as it always has. |
| 21:56 | Newmaniese | haha ok s/main goals/side effects/ :) |
| 22:01 | Newmaniese | so brosner, what do you think? |
| 22:02 | brosner | i think its something ill spend more time looking at after a merge. want to get these other items done first |
| 22:02 | brosner | i am a little hesitant right now |
| 22:02 | brosner | about its approach |
| 22:03 | brosner | what are the side-effects of emulating a module? |
| 22:04 | Newmaniese | you mean the url module? |
| 22:04 | brosner | types.ModuleType |
| 22:05 | Newmaniese | Yea, ok, Alex_Gaynor would know more about that, but I have been testing in the shell and I am pretty sure it behaves the way you expect it to |
| 22:06 | brosner | cross vm compatible? |
| 22:06 | Newmaniese | Haven't gone that far yet, but I will make sure to check before anything deemed usable is availible |
| 22:07 | brosner | cool |
| 22:07 | siudesign | empty: you there? |
| 22:07 | empty | siudesign: yep |
| 22:07 | brosner | hey siudesign |
| 22:08 | siudesign | Tis Robert Lofthouse, DjangoCon chair. In response to your blog post, i've sent you a little email. Hope you're interested ;) |
| 22:08 | siudesign | hey Brian |
| 22:09 | empty | siudesign: thanks. I'll check it now. :) |
| 22:09 | brosner | good to hear it got officially announced :) |
| 22:09 | siudesign | Yeah, finally! It's been a lot of fun, considering I live in London... and everyone else is in the US :) It's all worth it though |
| 22:10 | Newmaniese | brosner: Obviously we need you to look at this deeply and I am sure you are busy right now. If we continued this route would it be bad to have that one test changed? |
Page 3 of 3
← Previous
(293 total)