2008-7-17
| 00:01 | siudesign | If anyone is awake in here ;) can you check and see if you can view the placeholder page here: http://djangocon.org/ - Cheers! ;) |
| 00:01 | siudesign | :) |
| 00:05 | david`bgk | siudesign, I can view it :) |
| 00:05 | siudesign | ah, cool! :) |
| 00:06 | Gulopine | shows up for me |
| 00:07 | siudesign | Thanks guys! |
| 02:38 | paltman | anybody in here working on the recent commits on nfa? |
| 03:00 | brosner | paltman: what's up? |
| 03:01 | paltman | not sure where to start, there was a recent change to nfa that broke the generic inlines that i got working a couple weeks back |
| 03:01 | brosner | well lets get it fixed :) |
| 03:01 | brosner | what is the exception? |
| 03:02 | paltman | think it has to to with validation enforcing inheriting from BaseInlineFormset instead of BaseModelFormSet |
| 03:02 | paltman | which is most likely correct |
| 03:02 | paltman | but the interface is different on BaseInlineFormset |
| 03:02 | paltman | which is no problem |
| 03:03 | paltman | the more i look at it, the more it just points out problems with my solution |
| 03:03 | paltman | i was using modelformset_factory |
| 03:03 | paltman | instead of the inline factory |
| 03:03 | paltman | so my self.fk isn't getting set |
| 03:03 | paltman | and on an don |
| 03:03 | paltman | anyway, i am near to having it working again, just am stumped |
| 03:04 | brosner | ah ok |
| 03:04 | paltman | and what to provide for the parent_model |
| 03:04 | paltman | parameter |
| 03:04 | paltman | in inlineformset_factory |
| 03:04 | brosner | hmm |
| 03:04 | paltman | the model parameter is the model that has the generic field |
| 03:05 | brosner | i don't think i see a problem with making the validation validate a subclass of BaseModelFormSet |
| 03:06 | brosner | because you are effectively enforcing your own inline and inlineformset_factory is too bound to knowing the relationship |
| 03:06 | paltman | that would be a big help on making the generics work |
| 03:07 | paltman | or change the __init__ on BaseInline to allow me to specify self.rel_name/prefix |
| 03:07 | paltman | but not sure if that would take care of everythign |
| 03:08 | paltman | i am overriding get_queryset |
| 03:08 | paltman | and save_new |
| 03:08 | brosner | right |
| 03:08 | paltman | anyway |
| 03:08 | brosner | i don't see what else would fail |
| 03:08 | paltman | in what case? |
| 03:09 | brosner | i think the only problem is the strict validation |
| 03:09 | paltman | it's line 410 that is breaking me: self.rel_name = RelatedObject(self.fk.rel.to, self.model, self.fk).get_accessor_name() |
| 03:09 | paltman | i am setting my own rel_name and passing that as the prefix |
| 03:10 | paltman | with the BaseInline class I don't ahve the option to override that |
| 03:10 | brosner | the patch that is attached to the ticket for this works doesn't it? |
| 03:11 | paltman | i didn't think it would be a good idea for me to try to do something like override the __getattribute__ |
| 03:11 | paltman | doesn't anymore |
| 03:11 | paltman | the commit that enforces the inheritance from BaseInline instead of BaseModel breaks it |
| 03:12 | brosner | paltman: the GenericInlineFormset defines its own rel_name |
| 03:12 | paltman | right |
| 03:12 | paltman | but that is ignored |
| 03:12 | paltman | when changing inheritance to BaseInlineFormset |
| 03:12 | brosner | and rel_name is only BaseInlineFormset |
| 03:12 | paltman | probably don't need to set it |
| 03:13 | brosner | well you going to be changing it back though right? |
| 03:13 | brosner | ;) |
| 03:13 | paltman | i am just passing the value to set the prefix |
| 03:14 | paltman | i am halfway into changing stuff locally in my own project.generic.py to make it work with HEAD of nfa, but the BaseInlineFormset as my subclass doesn't seem right for generics |
| 03:14 | brosner | exactly. you convinced me to fix the django source so you can change it back :) |
| 03:15 | paltman | :) |
| 03:15 | paltman | thanks |
| 03:16 | brosner | no problem. just give me a bit before i can do it. need to find some dinner and take the dog for a walk |
| 03:16 | paltman | where is that validation rule? <would like to change it locally until you ahve a chance to commit> |
| 03:16 | brosner | sure |
| 03:16 | brosner | one sec |
| 03:17 | brosner | |
| 03:18 | brosner | |
| 03:18 | paltman | thanks |
| 03:45 | paltman | brosner: here is the patch to maybe save you a few minutes |
| 03:45 | paltman | |
| 04:52 | dwsBeta2 | does the buildbot have a url? |
| 05:00 | matt_c | dwsBeta2: buildbot.djangoproject.com |
| 05:01 | dwsBeta2 | thanks |
| 15:53 | salkot | What are reasons a "Ready for checkin" ticket might not make it in before 1.0? |
| 15:57 | david`bgk | time? |
| 15:57 | david`bgk | it seems that core-devs have a life too :) |
| 15:57 | salkot | david`bgk: Maybe my question is, what needs to be done after it's at that point? besides "svn ci" which doesn't take much time :) |
| 15:58 | david`bgk | I hope that tickets are tested one last time before the ci |