DjangoBot: #django-dev

heh

no, i was kinda hoping #7667 would get a test prior to a fix going in

I start watching a video for 30 min and 5 commits happen!

fs-rf might have already taken care of it, but i haven't gotten a chance to really play around with it yet

and can you help me figure out why the "func =" line was moved?

maybe i'm just having a slow day, but i can't see a reason

Sure, I'll take a look

it may be as simple as "because it was in the patch" :)

It was just moved, it's still there :P

alex, i realize that :) i just wasn't sure *why* it was moved

it might've just been an efficiency thing, i suppose

no sense getting the function if there's no valid file available

i know i've snuck things like that into patches before :(

Hehe

not that it much matters, it's gone after fs-rf anyway

Err, 5361

hahahah

you think that'll be good? hang on, i'll show you what it'll be like

Fixed #5361, #3567, #3621, #4345, #5619, #5655, #6450; refs #2983, #3119, #4339, #4948, #5485, #5966, #6009, #6390

Oh god, what have you done!

You are evil

not evil. just thorough

Gulopine: stop using the DjangoBot to flood the channel! it doesn't know any better. ;)

yeah, seriously

awww, brosner isn't here lol

The bot needs a saturation filter. :)

Gulopine is a good man, Jeffrey... and thorough

haha

wow, look at all the people who come running when DjangoBot goes postal

The DjangoBot is so naive

It'd be funny if the bot had auto kicking features, and kicked itself

and yeah, i guess *this* is why brosner never got around to implementing commit messages

hey guys, is the sprint still going on? do you want any help anywhere? everybody has gone to bed here in vilnius, so I have nothing to do ;)

RegexURLResolver has anyone ever thought that it could receive a module, not just a string? It would be a pretty simple change in the _get_urlconf_module function to check it

I am looking into reverse urls in NFA and thinking that the only reason we need that crazy root function is because RegexURLResolver doesn't accept modules directly

or objects

yea exactly

Newmaniese: Yeah, I had to make a small change to make it work, it's kind of a dumb change though, there are way better ways/places to d it

i talked with malcolm about it quite a while ago, but we never got anywhere

Newmaniese: I am thinking why should it even be modules? why not just something that has .urlpatterns (or the urlpatterns themselves)

It can be done with just 2 lines

Well, any object will work, module objects are just objects after all

Want me to submit an independent ticket about it?

I will write a patch, then I have a rough refactoring of NFA urls written that works with reverse and multiple admins

Alex_Gaynor: i have it done

Newmaniese: Yeah, it was done in the dpasted work I had, butit was ugly, I pretty much just prefilled the cache to prevent it from even doing an __import__

You got all the reverses in /dealt with the self.root_path issues?

forgive my ignorance, i'm just getting up to speed with django internals, but would what you're talking about relate to #285?

No this has to do with newforms admin and making it use urlconfs, instead of the hacky stuff it does now

well if the RegexURLResolver accepted objects, we can just include the url conf in site object and pass it directly in the url conf

as an include

what malcolm and i discussed was somehow making it accept arbitrary objects with a resolve() method

that could then use whatever logic made sense, regex or otherwise

thanks, Alex. I'm anxious to see 285 hit and solve so many problems with the way i have some servers configured :-)

let me finish things off and clean up a touch and I'll put it to dpaste and give you a chance to rip it apart

Nice :P

but that was really only a few-minute thing back in december

Well, what we are looking for is the ability to just stick any object that has a urlpatterns property in an include(), instead of just strings

hrm

i was looking for the ability to replace include() entirely :)

slap in an object instance instead

(which is what nfa does already)

but without having to specify (.*) at the end and all that nonsense

and withou reverse working

:P

well, malcolm did also insist that they also provide a .reverse() method

but meh, i don't have the time to put into it

Ok this is still really rough, It will need some string formatting for multiple admin sites and I am thinking about writing a decorator in the site object that will provide the auth checking. Also I am noticing a few print statements that need to be cleaned out. Tests fail due to the lack of permission checking (that's next on my list). Anyways tell me what you think: http://dpaste.com/63722/

so the url conf would go back to url(r'^admin/', include(admin.site))

Ok, the patch looks right(although it's missing a few files it feels like, it doesn't have the model admin stuff for example), also we need to add back the urls at r/

Alex_Gaynor: Why do I need to touch Model Admin?

and the r/ is in the urlconf

what better a time?

Well, we wnat ModelAdmin urls to be reversable as welll, if you take a look at my patch the ModelAdmin uses a psuedo urlconf as well

ahh gotcha